Chokboyz

Will be away of few days, so won't be able to work on bug fixing

Last bug fixes (i will post the code when i return) :

• Placed conveyor resulting from place/swap/transform terrain when no prior conveyor was present weren't functional. Fixed.

  Just needs to put a belt_present = true if the terrain is a conveyor when changing the terrain.

• No Step on sound option was taken in account. Fixed

  In fact there were no code using the step_sound variable from the terrain struct. All the sound were hardcoded, so i wrote the missing code.

  Which leads to an aesthetic question : should swamps play no sound when walking on them (like Exile III and original BoE) or the squish (trash) sound (default sound on the BoE editor) ?

• Affect Statistic Node probability check was wrong. It draws a number between 0 and 100 and if the number is strictly less than pic the stats were changed. Obviously even a 100 percent chance had 1 chance on 101 to fail. There may be others functions (dropping chances ?) affected by this glitch, will check it when i returns.

Unless there is a common (hopefully cross-platform) build, i fear it may.

Good luck, with your modifications to the editor (a "boat" icon, would indeed be useful )

Chokboyz

Print out the current directory location (i don't know what function is used on Mac, but it must have an equivalent to pwd or GetCurrentDirectory). If it's okay, it's one less possible problem.

Chokboyz

The "town dies on day X" is also affected by the funky day_reached function (not the node).

Moreover, the editor was incorrectly preventing the designer to use the 10 major event (in fact, both -1 and 0 values don't do a thing, but the error text was saying to choose value between 0 and 9, -1 being do nothing). That has been corrected.

Here is the changed lines 1029-1030 in the TOWNOUT.cpp file (ormus' build scenario editor code) :

if (cre(town.town_chop_key,-1,10,"The event which prevents the town from becoming abandoned must be from 1 to 10 (-1 or 0 for none)."

,"",832) == TRUE) return FALSE;

Apart from that, the Hide Town node being fixed and working, i assume that no legacy scenario used this broken feature (the check was done in spec2a instead of spec1b, so maybe someone figured this out ?) ...

Chokboyz

Edit : and a nifty one to finish : a character without the nimble trait is actually better at disarming trap than a nimble one

Corrected of course (- to +).

Oh nothing, just a wink to the topic of the day

Chokboyz

I may be wrong, but i though FSPathMakeRef used POSIX paths :

Blades of Exile Scenarios/ vs Blades of Exile Scenarios:

Also, in the windows code, the custom scenario problem was caused by the program looking in the wrong directory (because an OpenFileName function changed the working directory.

Hope it helps,

Chokboyz

That looks like a uninitialized or bad initialized pointer (doesn't find anything than access violation crash) ...

Unfortunately, i have no way to compile the mac code to test that

Chokboyz

The Appear/Disappear on Events cases weren't working either. That has been fixed, the problem was exactly the same.

While i was at it, i changed the dialogs in the Major Event has Occured Node so that it says to choose a value between 1 and 10 (not 0 and 9). It was the same glitch as the Place Town Encounter Node.

That was indeed an head-scratching choice ... I think i may be a leftover from the Exile III to BoE porting though.

Fixing that (or not) without breaking anything is the real challenge

Chokboyz

The Appear/Disappear on day X feature has been fixed ...

All the monsters are placed in a town the first time you enter it and won't be until the town is reinitialized (by the debug function or other). They are not placed again when you reenter the town to save time.

The first problem was that the part of the code checking if there's a monster to Appear/Disappear on day X in the town, was done during the first time placement of the monsters and subsequently ignored (in TOWN.cpp, line 197 of Ormus' build). The checks needs to be put outside of the if (monsters_loaded == FALSE) loop.

The second was that setting c_town.monst.dudes[ i ].active to 0 may work in the previous loop, but out of it, it must be set to 1.

Finally (the funky part ) when you check if a day is reached, the game checks that the day + 20 is reached (a comment in the code informs us that it's "to give party bonus time"). So even if you apply the fix above, if you specify that a monster appears on day 3, it will appears on day 23.

The Disappear on day X part is the same (adapted) problem.

Sometimes Appears Here A/B/C should works, but I don't know if Appear/Disappear on Events does.

Chokboyz

P.S : Attached, my version of the loop just before the if(monsters_loaded == FALSE)

The bug where town couldn't be hid is fixed (assuming that won't break any compatibility with legacy scenarios ; why would would one try to hide a critical town knowing that the function doesn't work as intended ?).

The problem was that the value in 2a was checked instead of the value in 1b.

In SPECIALS.cpp, in town_spec, case 17 replace the line

else party.can_find_town[spec.ex1a] = (spec.ex2a == 0) ? 0 : 1;

by

else party.can_find_town[spec.ex1a] = (spec.ex1b == 0) ? 0 : 1;

To CM :

Why not When everything works as intended though ...

Chokboyz

• Switch between legacy Town Place Encounter Node (for legacy compatibility) or fixed one (so that you can make full use of the 10 special groups in scenario editor).
  Value : party.stuff_done[309][0]
• Switch between legacy Resurrection Node (at least for easter eggs ) or fixed one (so that only present pc are resurrected, not the full party).
  Value : party.stuff_done[309][1]
• Switch between Waterfalls working in Town or not (so that the user/scenario designer decided if the waterfall works in Town ; maybe legacy compatibility ?).
  Value : party.stuff_done[309][2]

Oops, I forget a to end the case 'K' with a break in the debug function above (incidentally making the scenario end each time you call it ). Fixed

I've create a new file menu entitled "compatibility options" where we would give the player the choice to use old legacy (bugged) function (to play old scenario) or new fixed ones. So far, i've only put the "Legacy Place Town Encounter ?" option, but i'll add party ressurection or working waterfalls on town.

Can someone confirm that SDF 309 is never used in the game (i didn't see that in the code) ? I would like to make it the compatibility switch array.

Concerning the Monster 0 problem, was the scenario editor Delete Monster function the only problem ? (no problem on gamecode side ?)

Nice to see the editor taking good shape

Chokboyz

To Ishad Nha : i've been merging our codes into a "clean build" that could serve as a base for future programmation.

That raises several questions :

1. In GRAPHUTL.cpp, line 143 of your code, the hdcMem3 parameter should be destDC (copy/paste leftover i think )
2. In GLOBVAR.cpp, line 450 of your code, you've changed the char button_def_key[150] array. Why ? Is it a bug fix ?
3. You shouldn't substract 200 to the help message in most of the case. Indeed, having a 200 + number_of_message send to the function give_help() forces the display of the help message, even if "don't give help message" is checked. That way if someone click on the help button and this option is set, the message is given. For example, with the current code, the alchemy help message is unreachable as soon as the "don't give help message" option is set.
4. In TOWN.cpp, line 1068, you've set the two last parameters of map_world_rect to 400. Why ? Another bug fix ?
5. I've incorporated your nice extended debug mode. I've cleaned it a little (mainly message the player when he is trying to do something not allowed, e.g flying in town ...), tweaked the Leave Town debug function so that it doesn't put you in start town but rather ask you to choose in which direction to quit the town and finally made the End Scenario functionnal.

   The problem was that the end_scenario flag was put to false at the beginning of each action, so i make it skip the check and directly end the scenario when the debug function is called.

    

   Here is the beginning of the code (the rest is untouched) :

    

   Click to reveal..

   Boolean handle_keystroke(WPARAM wParam, LPARAM lParam)

   {

   Boolean are_done = FALSE;

   POINT pass_point;

   short i,j,k;

   POINT terrain_click[10] = {{150,185},{120,215},{150,215},{180,215},

   {120,185},{150,185},{180,185},

   {120,155},{150,155},{180,135}};

   char talk_chars[9] = {'l','n','j','b','s','r','d','g','a'};

   char chr;

    

   short x,y;

   location loc;

    

   if (in_startup_mode == TRUE)

   return FALSE;

    

   chr = (char) wParam;

    

   if (overall_mode == MODE_TALKING) {

   if (chr == ' ')

   chr = 'g';

   for (i = 0; i < 9; i++)

   if (chr == talk_chars) {

   pass_point.x = preset_words.word_rect.left + 9;

   pass_point.y = preset_words.word_rect.top + 9;

   are_done = handle_action(pass_point,wParam,-1);

   return are_done;

   }

   }

   else if (overall_mode == MODE_SHOPPING) { // shopping keystrokes

   for (i = 0; i < 8; i++)

   if (chr == 97 + i) {

   pass_point.x = shopping_rects[1].left + 9;

   pass_point.y = shopping_rects[1].top + 9;

   are_done = handle_action(pass_point,wParam,-1);

   return are_done;

   }

   }

    

   if ((overall_mode != MODE_TALKING) && (overall_mode != MODE_SHOPPING)) {

    

   for (k = 0; k < (short) LOWORD(lParam); k++)

   switch(chr)

   {

   case 'D':

   if (in_scen_debug)

   {

   in_scen_debug = FALSE;

   ASB("Debug mode OFF.");

   }

   else

   {

   in_scen_debug = TRUE;

   ASB("Debug mode ON.");

   }

   print_buf();

   break;

   case '?':

   if (is_out()) FCD(1079,0);

   if (is_town()) FCD(1080,0);

   if (is_combat()) FCD(1081,0);

   break;

    

   case '1': case '2': case '3': case '4': case '5': case '6':

   pass_point.x = pc_buttons[((short) chr) - 49][0].left + 1 + PC_WIN_UL_X;

   pass_point.y = pc_buttons[((short) chr) - 49][0].top + PC_WIN_UL_Y;

   are_done = handle_action(pass_point,wParam,-1);

   return are_done;

   break;

    

   case '9':

   pass_point.x = item_screen_button_rects[6].left + ITEM_WIN_UL_X;

   pass_point.y = item_screen_button_rects[6].top + ITEM_WIN_UL_Y;

   are_done = handle_action(pass_point,wParam,-1);

   return are_done;

   break;

    

   case ' ':

   if (overall_mode == 14) { // cast multi-target spell, set # targets to 0 so that

   // space clicked doesn't matter

   num_targets_left = 0;

   pass_point = terrain_click[5];

   are_done = handle_action(pass_point,wParam,-1);

   return are_done;

   }

   if (overall_mode == 11)

   spell_cast_hit_return();

   break;

    

    

   case 'z':

   if (((overall_mode >= 10) && (overall_mode < 20)) || (overall_mode == 37)) {

   set_stat_window(current_pc);

   put_item_screen(stat_window,0);

   }

   else {

   set_stat_window(0);

   put_item_screen(stat_window,0);

   }

   break;

    

   case '=':

   if (in_scen_debug) {

   party.gold += 100;

   party.food += 100;

   for (i = 0; i < 6; i++) {

   adven.main_status = MAIN_STATUS_ALIVE;

   adven.cur_health = 100;

   adven.cur_sp = 100;

   }

   adven.giveXP(25);

   refresh_store_items();

   for (i = 0; i < 6; i++)

   for (j = 0; j < 62; j++) {

   adven.mage_spells[j] = TRUE;

   adven.priest_spells[j] = TRUE;

   adven.skills[9] = 7;

   adven.skills[10] = 7;

   }

    

   add_string_to_buf("Debug: Add stuff and heal. ");

   print_buf();

   put_pc_screen();

   }

   break;

    

   // case 'A': Alchemy <= bad idea, there's already a case 'A' - Alchemy. And working in town only.

   case 'B': // Leave town

   if (in_scen_debug) {

   party.stuff_done[304][0] = 0;

   if(overall_mode == MODE_OUTDOORS){

   add_string_to_buf("Debug - Leave Town: You're not in town !");

   print_buf();

   break;

   }

   overall_mode = MODE_OUTDOORS;

   position_party(party.outdoor_corner.x,party.outdoor_corner.y,party.p_loc.x,party.p_loc.y);

   clear_map();

   add_string_to_buf("Debug: Leaving town...");

   add_string_to_buf("Choose which direction to go.");

   print_buf();

   put_pc_screen();

   }

   break;

    

   case 'C': // Clean up

   if (in_scen_debug) {

   for (i = 0; i < 6; i++) {

   adven.status[sTATUS_POISON] = 0;

   if (adven.status[sTATUS_BLESS] < 0)

   adven.status[sTATUS_BLESS] = 0;

   if (adven.status[sTATUS_HASTE] < 0)

   adven.status[sTATUS_HASTE] = 0;

   adven.status[sTATUS_WEBS] = 0;

   adven.status[sTATUS_DISEASE] = 0;

   adven.status[sTATUS_DUMB] = 0;

   adven.status[sTATUS_ASLEEP] = 0;

   adven.status[sTATUS_PARALYZED] = 0;

   adven.status[sTATUS_ACID] = 0;

   }

   add_string_to_buf("Debug: You get cleaned up!");

   print_buf();

   put_pc_screen();

   }

   break;

   // case 'D': toggle Debug mode <= bad idea, there's already a 'D' case.

   //Can be moved out of this function to allow the character to switch debug mode during dialogues or shopping though.

   case 'E': // Miscellaneous help

   if (in_scen_debug) {

   party.stuff_done[305][0] = 10;

   party.stuff_done[305][2] = 10;

   party.stuff_done[305][3] = 10;

   add_string_to_buf("Debug: Sanctuary, Detect, Lavawalk!");

   print_buf();

   put_pc_screen();

   }

   break;

   case 'F': // Flight

   if (in_scen_debug) {

   if (overall_mode == MODE_TOWN){

   add_string_to_buf("Debug - Flying: Not while in Town !");

   print_buf();

   break;

   }

   party.stuff_done[305][1] = 10;

   add_string_to_buf("Debug: You start flying!");

   print_buf();

   }

   break;

   case 'H': // Heal PCs and restore their SP

   if (in_scen_debug) {

   party.gold += 100;

   party.food += 100;

   for (i = 0; i < 6; i++) {

   if ((adven.main_status > MAIN_STATUS_ALIVE) && (adven.main_status < MAIN_STATUS_FLED))

   adven.main_status = MAIN_STATUS_ALIVE;

   }

   adven.heal(250);

   adven.restoreSP(100);

   add_string_to_buf("Debug: Heal.");

   print_buf();

   put_pc_screen();

   }

   break;

   case 'K':

   if (in_scen_debug) {

   for (i = 0; i < T_M; i++) {

   if ((is_combat()) && (c_town.monst.dudes.active > 0) && (c_town.monst.dudes.attitude % 2 == 1))

   c_town.monst.dudes.active = 0;

    

   if ((c_town.monst.dudes.active > 0) && (c_town.monst.dudes.attitude % 2 == 1)

   && (dist(c_town.monst.dudes.m_loc,c_town.p_loc) <= 10) )

   damage_monst(i, 7,1000,0, 4);

   }

   initiate_redraw();

   add_string_to_buf("Debug: Kill things.");

   print_buf();

   break;

   }

   // case 'L': automap <= don't know exactly what you want to do here ... Reveal all map ?

   // case 'M': repeat Mage spell <= same here

   case 'N': // End scenario

   if (in_scen_debug) {

   reload_startup();

   in_startup_mode = TRUE;

   in_scen_debug=FALSE;

   draw_startup(0);

   menu_activate(1);

   if (FCD(901,0) == 2) save_file(1);

   }

   break;

   case 'O': // Location

   if (is_town()) {

   loc = (overall_mode == MODE_OUTDOORS) ? party.p_loc : c_town.p_loc;

   sprintf ((char *) c_line, "Debug: You're at x %d y %d in town %d.",

   (short) loc.x, (short) loc.y, c_town.town_num);

   }

   if (is_out()) {

   loc = (overall_mode == MODE_OUTDOORS) ? party.p_loc : c_town.p_loc;

   x = loc.x; y = loc.y;

   x += 48 * party.outdoor_corner.x; y += 48 * party.outdoor_corner.y;

   sprintf ((char *) c_line, "Debug: You're outside at x %d y %d.",x,y);

   }

   add_string_to_buf((char *) c_line);

   print_buf();

   break;

   // case 'P': repeat Priest spell

   case 'Q': // Magic map

   if (in_scen_debug) {

   if (overall_mode == MODE_OUTDOORS) {

   for (i = 0; i < 96; i++)

   for (j = 0; j < 96; j++)

   make_explored(i,j);

   }

   else {

   for (i = 0; i < 64; i++)

   for (j = 0; j < 64; j++)

   make_explored(i,j);

   }

   clear_map();

   add_string_to_buf("Debug: Magic Map.");

   print_buf();

   }

   break;

   case 'R': // Return to Start

   if (in_scen_debug) {

   if (party.in_boat >= 0) {

   add_string_to_buf(" Not while in boat. ");

   break;

   }

   force_town_enter(scenario.which_town_start,scenario.where_start);

   start_town_mode(scenario.which_town_start,9);

   position_party(scenario.out_sec_start.x,scenario.out_sec_start.y,

   scenario.out_start.x,scenario.out_start.y);

   center = c_town.p_loc = scenario.where_start;

   redraw_screen(0);

   add_string_to_buf("Debug: You are moved... ");

   print_buf();

   }

   break;

   /* case 'S': // Set a SDF <= must wait after we've done a "ask a question to player" dialog

   if (in_scen_debug) {

   break;

   }

   case 'T': // Move to new Town <= idem

   */

   case 'W':

   if(in_scen_debug){

   refresh_store_items();

   add_string_to_buf("Debug: Refreshed jobs/shops. ");

   print_buf();

   }

   break;

   case '<': // Advance clock by one day

   if (in_scen_debug) {

   ASB("Debug: One day passes...");

   print_buf();

   party.age += 3700;

   put_pc_screen();

   }

   break;

   case '>':

   if(in_scen_debug){

   ASB("Debug: Towns have short memory.");

   ASB("Your deeds have been forgotten.");

   print_buf();

   for (i = 0; i < 4; i++)

   party.creature_save.which_town = 200;

   }

   break;

   case '/': // Help list

   if(in_scen_debug){

   ASB(" Debug hot keys");

   ASB(" B: Leave town");

   ASB(" C: Get cleaned up");

   ASB(" D: Toggle Debug mode");

   ASB(" E: Sanctuary, Detect, Lavawalk");

   ASB(" F: Flight");

   ASB(" H: Heal");

   ASB(" K: Kill things");

   ASB(" N: End Scenario");

   ASB(" O: Location");

   ASB(" Q: Magic map");

   ASB(" R: Return to Start");

   ASB(" W: Refresh jobs/shops");

   ASB(" =: Heal, increase magic skills");

   ASB(" <: Make one day pass");

   ASB(" >: Towns forgive you");

   ASB(" /: Bring up this list");

   print_buf();

   }

   break;